Fix build with Python 3.13 #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 has changed how `locals()` works [1], so this code needs to be a bit more explicit. [1] https://docs.python.org/3.13/whatsnew/3.13.html#defined-mutation-semantics-for-locals
|
I am thinking about changing implementation of this to something like this..: edited: I linked an alternative method of obtaining the version, it seems to me that it will be better, do you agree? |
|
I'm sure that's possible, but I went for the minimal change here. |
|
Anyway thank you for pointing on this. I am not sure will I publish beta wheels for Python 3.13 in the upcoming release or it will come a month/two later with the drop of Closed in favour of #259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 has changed how
locals()works [1], so this code needs to be a bit more explicit.[1] https://docs.python.org/3.13/whatsnew/3.13.html#defined-mutation-semantics-for-locals